Closed KerstinFaye closed 1 month ago
Ready on TEST 🧑💻
@bprusinowski I added the link in the chevron when clicking on the tab and also the field underneath the "title & description" in the editing mode.
Observations from my test on TEST
In published mode, the left arrow seems to be missing, and the tab is not aligned with the rest of the frame. I assume that the arrow should only appear once the user scrolls, but the indent before the first tab looks a bit strange to me. see: https://test.visualize.admin.ch/en/v/tFKBIr7nwSRG?dataSource=Prod and screen shot below
i noticed there is no character limit on the tab label...should we consider introducing a character limit for the tab labels to avoid extremely long labels as can be seen here: https://test.visualize.admin.ch/en/v/tFKBIr7nwSRG?dataSource=Prod. If the label is very long, it may be hard for the user to discover additional charts in a chart published in tab layout. This would be a new issue 💡
Tested with 15 charts here: https://test.visualize.admin.ch/en/v/Nv72Y4_HupmB?dataSource=Prod scrolling is fluid.
Hi @sosiology, thanks for testing 🙇♂️ Maybe we could combine the two first things in a new issue? The behavior of having an empty space is there by default in MUI (https://mui.com/material-ui/react-tabs/#scrollable-tabs), but we could try to change this 👍
Thanks for the explanation @bprusinowski i created a new issue here #1776
Thanks @sosiology for the observations.
@KerstinFaye thanks for your feedback. If you have any other ideas or improvements on the topic of tab labels please adde them to the new issue here #1776
Problem: Users had difficulty switching between tabs when they had many chart tabs open. They did not realize that they could scroll horizontally. Tab label names have been super long since they were the same as the chart title.
Improvement:
Design: Figma Design