visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
32 stars 3 forks source link

Combo Chart Axis Title improvements #1885

Closed noahonyejese closed 5 days ago

noahonyejese commented 1 week ago

This PR


How to test

  1. Go to this link
  2. Create a new visualization (f.e Einmalvergütung für Photovoltaikanlagen) - works better with this
  3. Select Column + Line Chart
  4. Select these f.e image
  5. These are long Axis Title's allowing you to view the full potential
  6. Resize the screen to any size you'd like
  7. See how text is not overflowing the label ✅
  8. See how label is not covering the chart ✅

Optionally

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 7:34am
sosiology commented 1 week ago

@noahonyejese thank you for preparing. I check on the deployment preview https://visualization-tool-git-fix-fix-minor-bugs-ixt1.vercel.app/en/v/MNoS3_CeyAIv?dataSource=Prod and it appears like the bottom of the boxes are cut off.

image
noahonyejese commented 6 days ago

@noahonyejese thank you for preparing. I check on the deployment preview https://visualization-tool-git-fix-fix-minor-bugs-ixt1.vercel.app/en/v/MNoS3_CeyAIv?dataSource=Prod and it appears like the bottom of the boxes are cut off. image

@sosiology true I have noticed that at a certain screen size the bottom gets cut off a bit - this has been solved

sosiology commented 5 days ago

Nice @noahonyejese LGTM!

Tested with this chart and reduced browser window and labels still look good! https://visualization-tool-git-fix-fix-minor-bugs-ixt1.vercel.app/en/v/Ap4_IQYbBo0i?dataSource=Prod. Once the PR is merged i will check again on TEST