visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
32 stars 3 forks source link

Hierarchies - Bathing water quality : no label or no entrie for some stations #584

Closed ortnever closed 2 years ago

ortnever commented 2 years ago

Some station labels are not displayed in the preview table. Example: CH11005 Solothurn (BAQUA SO), CH19006 Badi Tennwil (BAQUA_AG) etc. The same stations do not appear in the left filter either. They appear with label in the hierarchical tree but without color. Notice that all observation sites appear correctly in the shared dimension and are mapped in the Cube Creator, except 5 stations which could not be mapped in the Cube Creator: CH21098 to CH211002.

To Reproduce

  1. Open test.visualize.admin.ch
  2. Search "Bathing water quality" (Include draft datasets)
  3. No label in the preview table for some stations, e.g. CH11005 (Solothurn), CH19006 (Badi Tenwil, CH17028 (Strandabd Stampf, Zürichsee)
  4. Start a visualization
  5. The station does not appear in the drop list of the filter of the dimension "Observation location" on the left.
  6. Choose "Observation Location" as "color".
  7. The station 11005 Solothurn appears correctly under BAQUA_SO in the hierarchical tree but has no color (value) Screenshots image image image

Environment (please complete the following information):

ptbrowne commented 2 years ago

@l00mi When I look at the unique values inside the cube, it seems to me that some of the stations are not mapped to a hierarchical concept, leading to some stations not having a correct label.

See https://s.zazuko.com/8xiAoX , I think there might be something to fix there.

In the meantime, I will make it so that hierarchical values that are being showed are only the ones that are in the data.

ortnever commented 2 years ago

...and some observation sites do not appear in the hierarchical tree at all. For example, all sites of the monitoring programmes Baqua AG and Baqua BE.

ptbrowne commented 2 years ago

I do not see baqua ag nor baqua be in the hierarchy on https://int.cube-creator.lindas.admin.ch/app/hierarchies/dimension!!hierarchy!!baqua-network-station

l00mi commented 2 years ago

Missing BE AG

@ortnever this were not in the initial dataset which i used to build the hierarchies. Would you mind to add these manually?

Missing entries (not linked once)

I just fixed the before missing stations in the Shared Dimension. But that said it might always also have strings (Not concepts) of missing data. Ideally in this case they would be still shown, but with the strings.

Finally the overall approach I would imagine is, collect all stations (in this example), which can be found in the hierarchy get added to the hierarchy tree in the widget. All other, not in the hierarchy present concepts get added to the end as a simple list of the widget. Potentially with a small divider in-between. (We will almost never have perfect data, so we will need to show also special cases.) I understand that this might be out-of-scope for this project phase.

l00mi commented 2 years ago

@ortnever I still miss the following entries at Swisstopo:

Screenshot 2022-06-13 at 16 04 05

E.g. https://geo.ld.admin.ch/inlandwaters/bathingwater/CH21098

ortnever commented 2 years ago

I don't know why...The station heve been delivered with the geo layer and they are published on map.geo.admin.ch I will ask Pasquale tomorrow.

ortnever commented 2 years ago

@l00mi I tried several times to add Baqua_ag and baqua_be in the hierarchy but I get always the same error message. I closed and opened it again but no success. image

l00mi commented 2 years ago

@ortnever that is now all solved, correct?

ortnever commented 2 years ago

No, I could not add BAQUA AG and BAQUA BE. I do not really know how I have to proceed. I cannot open the Dynamic properties.

Concerning the mapping with Swisstopo Layer:

image

l00mi commented 2 years ago

Yes that is thought not the same issue. This issue is solved, the other is tracked here https://github.com/zazuko/cube-creator/issues/1253. I propose to close this issue in favor of the other. Anyhow, visualize can nothing do about that.

ortnever commented 2 years ago

ok.