search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

button <reset map> doesn't work on published maps #665

Closed Rdataflow closed 2 years ago

Rdataflow commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. go to published map on https://test.visualize.admin.ch/v/2q3Ny4iW-9Rm
  2. rotate / tilt the map view
  3. click on reset map button
  4. ... oddly nothing happens

Expected behavior reset to initial view

Screenshots image

Environment (please complete the following information):

cc @afoletti

bprusinowski commented 2 years ago

Thanks for raising this @Rdataflow, indeed we only reset the map to its initial position (x & y), not taking rotations into consideration. I will try to fix this in this sprint.

ptbrowne commented 2 years ago

@Rdataflow Is rotation+tilting a function that should be activated / deactivated completely on the maps ? Do you need rotation + tilting ?

AFoletti commented 2 years ago

@Rdataflow Is rotation+tilting a function that should be activated / deactivated completely on the maps ? Do you need rotation + tilting ?

My 2 cents coming from a long experience in the BGDI: Rotation is nice to have, but I personally could live without. It's mostly a niche usecase. Tilt is useless until the moment when you will implement true 3D plots on the map (which for instance would be fantastic. Who does not love some 3D charts like those?). Since this is for the moment being whisful thinking, I would be in favor of eliminating it since adds confusion without actually any real gain.

If I, as a data publisher, would have the option to block those two interactions for my maps, I would do so 99% of the time.

Rdataflow commented 2 years ago

you may deactivate it, as currently there is no need for it 👍

Rdataflow commented 2 years ago

@bprusinowski tillt and rotate is still possible. RMB still allows to rotate and tilt. observed today on https://test.visualize.admin.ch/v/bOkX-KXoEgsp?dataSource=Int image

bprusinowski commented 2 years ago

Hi @Rdataflow, that's true, thanks for noticing! We did a bigger refactor of the map chart (code-wise) and I think it got lost along the way. I am disabling this feature right now.

Rdataflow commented 2 years ago

@bprusinowski well done 👍