visualizingthefuture / examples-repository

Repository for https://visualizingthefuture.github.io/examples-repository
Other
5 stars 2 forks source link

First pass of parsing script #92

Closed cassws closed 3 years ago

cassws commented 3 years ago

Pausing for code review! This script runs locally via eg:

python parse_google_sheet.py test_datavis.csv test_output.json

With delimeter defaulting to | (and no whitespace). I ran the above line with a test CSV (for audience level only), moved test_output.json to _data, changed _config.yml, and was able to see:

image

So I think we're in good shape re: #89 ! Note that this currently just checks ALL possible strings for the pipe by default. Also I want to double check how this strategy will encounter weird unicode characters as that's always a possibility in this type of program. @amzoss any feature requests for this script?

amzoss commented 3 years ago

This is looking great! I think it's fine as it is. If I had any suggestions, it would just be to add an optional argument to change the delimiter, and it sounds like you might already have had that idea, so no hurry on that.