URL Query Params are encoded due to buggy version of normalize-url

visualjerk / quill-magic-url

Automatically convert URLs to links in Quill

MIT License

126 stars 43 forks source link

URL Query Params are encoded due to buggy version of normalize-url #84

Open aashutoshrathi opened 2 years ago

aashutoshrathi commented 2 years ago

We currently use https://github.com/sindresorhus/normalize-url ^4.5.1 to normalize URLs and it's buggy. The bug is simple that, they don't decode back the queryParameters after it's encode as side-effect of sort().

Fixed later here: https://github.com/sindresorhus/normalize-url/pull/158

Solution: Upgrade to newer version of normalize-url

aashutoshrathi commented 2 years ago

There is one issue though, normalize-url went to Full ESM only in v7.0.0 and the issue was fixed in the latest version i.e v7.0.3 cc: @visualjerk