search

visualphoenix / jenkins-xml-to-jobdsl

Translates jenkins xml jobs into jobdsl groovy using ruby and nokogiri
Apache License 2.0
44 stars 16 forks source link

Refactoring configure block handling. #15

Closed hekaldama closed 7 years ago

hekaldama commented 7 years ago

This gives us the ability to use plain ruby datastructures (Array, Hash, and String) to try and describe the syntax of the configure block. It treats the whole configure block like an Array of lines and iterates through just printing the lines faithfully.

visualphoenix commented 7 years ago

Sounds good. Let's chat tomorrow. On Wed, Dec 28, 2016 at 7:40 PM Adam Avilla notifications@github.com wrote:

@hekaldama commented on this pull request.

In jenkins-xml-to-jobdsl.rb https://github.com/visualphoenix/jenkins-xml-to-jobdsl/pull/15:

@@ -620,17 +620,17 @@ def process(job_name, depth, indent)

   when 'notifyCulprits'

     puts " " * currentDepth + "notifyScmCulprits(#{i.text})"

   when 'notifyOnBuildStart'

  • configureBlock << "'#{i.name}'(#{i.text})"

  • configureBlock << "(ircNode / '#{i.name}').setValue(#{i.text})"

Can you make the PR only about the configure block?

I can understand why you would want this, but would rather go over it in detail tomorrow if you have time and then still see if you would like a change to the PR.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/visualphoenix/jenkins-xml-to-jobdsl/pull/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYDv9-gKlnBlo3CxXLUKG8QKBNyC8b_ks5rMwFdgaJpZM4LXRkH .