visulima / packem

A fast and modern bundler for Node.js and TypeScript.
MIT License
3 stars 0 forks source link

fix: Use fileURLToPath for path normalization in createStub and update dependencies #23

Closed prisis closed 2 weeks ago

prisis commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes involve updates to the package.json files for both the root and the packem package, reflecting version increments for various dependencies. Additionally, modifications were made to the create-stub.ts file, where import statements were adjusted, and the handling of the resolvedEntry variable was refined to improve module path resolution.

Changes

File Path Change Summary
package.json Updated nx package version from ^19.8.1 to ^19.8.2.
packages/packem/package.json Updated versions for several dependencies: @rollup/plugin-commonjs (26.0.3 to 28.0.0), @rollup/plugin-replace (5.0.7 to 6.0.1), jiti (2.0.0-rc.1 to 2.0.0), oxc-parser (0.29.0 to 0.30.1), and rollup (4.22.2 to 4.22.4).
packages/packem/src/jit/create-stub.ts Modified import statements and changed handling of resolvedEntry to use fileURLToPath instead of normalize. Added assignment for _module from jiti.import.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Packem
    participant Jiti

    User->>Packem: Request module
    Packem->>Packem: Resolve entry
    Packem->>Jiti: Import module
    Jiti-->>Packem: Return module
    Packem-->>User: Provide module

Poem

🐇 In the garden, changes bloom,
Versions rise, dispelling gloom.
With paths now clear, and imports bright,
Our code hops forward, pure delight!
Dependencies dance, a joyful cheer,
A rabbit's joy, the spring is near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
:placard: Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 weeks ago

Thank you for following the naming conventions! 🙏

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rollup/plugin-commonjs@28.0.0 None +2 318 kB shellscape
npm/@rollup/plugin-replace@6.0.1 None 0 23.3 kB shellscape

🚮 Removed packages: npm/@rollup/plugin-commonjs@26.0.3, npm/@rollup/plugin-replace@5.0.7

View full report↗︎

prisis commented 2 weeks ago

@coderabbitai give me a good MR title

coderabbitai[bot] commented 2 weeks ago

[!TIP] For best results, initiate chat on the files or code changes.

@prisis: How about "fix: Use fileURLToPath for path normalization in createStub and update dependencies"?

This title highlights the main changes made in the MR, including improving module path resolution by replacing normalize with fileURLToPath in the createStub function, and updating several dependencies to their latest versions.