search

visurel / iconify-angular

Angular implementation of Iconify, strongly inspired from Iconify-React.
19 stars 14 forks source link

update deps and some tests #1

Closed peterennis closed 5 years ago

peterennis commented 5 years ago

Capture647

NOTE: Failing tests. Some updates include CUSTOM_ELEMENTS_SCHEMA but I could not get it to play nicely.

Capture648

visurel commented 5 years ago

Thanks for the contribution! I personally don't like using CUSTOM_ELEMENTS_SCHEMA, especially on a smaller library and since we don't have tests yet, I'd like to just keep it as is. Is there any specific reason for the dependency bumps?

peterennis commented 5 years ago

Ok. I was expecting test to pass. I am investigating using iconic with a StencilJS component. They use custom element schema with ionic/angular.