vit-project / vit

VIT is a lightweight, fast, curses-based front end to Taskwarrior
MIT License
493 stars 51 forks source link

[VT-8] Add support for "modify task" #30

Closed taskwarrior closed 6 years ago

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-04-06T21:34:33Z says:

It would be nice to have support for modifying a task in Vit.

I would prefer to have the binding be 'm'. I don't use priorities. I think that everyone uses 'modify' but only some use priorities. I would favor having a two-key binding for priorities. For example, capital 'P'. Thus, to get high priority, medium priority, low priority, one would do 'P-h', 'P-m', 'P-l', respectively.
taskwarrior commented 6 years ago

Migrated metadata:

Created: 2013-04-06T21:34:33Z
Modified: 2014-02-09T01:14:58Z
taskwarrior commented 6 years ago

David Patrick on 2013-04-06T21:53:28Z says:

+1

taskwarrior commented 6 years ago

steve rader on 2013-04-06T21:55:31Z says:

Scott Kostyshak wrote:

It would be nice to have support for modifying a task in Vit.

what do you mean by "modify"?

there's already... 'e' for edit (task NNN edit) 'c' for change description (task NNN NEW DESCRIPTION) ":s/OLD/NEW/" for modify description (task NNN modify /OLD/NEW)

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-04-06T22:06:08Z says:

steve rader wrote:

Scott Kostyshak wrote:

It would be nice to have support for modifying a task in Vit.

what do you mean by "modify"?

there's already... 'e' for edit (task NNN edit) 'c' for change description (task NNN NEW DESCRIPTION) ":s/OLD/NEW/" for modify description (task NNN modify /OLD/NEW)

Ah, "change" is what I'm looking for. 'c' currently uses Taskwarrior's 'modify' command to change the description. But it can do more than that.

The following command changes the date so that it is due tomorow (and the description is left unchanged):

task  modify due:tomorrow

Similarly, one can change tags, UDAs, and more with the 'modify' command. Now that I know, I think that change does what I want. The question now is whether its good to keep the name as 'change' when most Taskwarrior users are used to 'modify'. At a minimum, I think that the help should say that 'change' can do more than change a description.

taskwarrior commented 6 years ago

David Patrick on 2013-04-06T22:36:44Z says:

I like that line of thinking Scott, "modify" is sort of universal, powerful, and it's consistent with taskwarrior use. It might allow some kebinding decluttering too.. if hitting "m" resulted in a partially completed task command. As an example, suppose I was already looking at vit with a filter, and I hit "m" I would see

task proj:foo +tag modify >

from there it's easy-peasy to add/change/remove just about anything! description, project dates, whatever, and in a way that re-enforces CLI usage, and not as an alternative to it.

taskwarrior commented 6 years ago

steve rader on 2013-04-06T23:34:42Z says:

Oops! I ahem don't really use stuff beyond descriptions and priorities, so I had forgotten the functionality here: 'c' allows you to do "task NNN modify".

Scott - try 'c' and then...

 due:tomorrow

David - try 'c' and then...

 proj:foo +tag

Elegant, no?

The problem is, I think, is the doc...

 cmd   c STRING        change the current task's description

...should be...

 cmd   c STRING        modify (change) the current task

...or something?

taskwarrior commented 6 years ago

David Patrick on 2013-04-06T23:44:54Z says:

or something! that's excellent!

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-04-06T23:49:08Z says:

Works well. I think the new help description is good.

Thanks Steve.

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-09-27T23:14:15Z says:

This should go into VIT 1.2.

taskwarrior commented 6 years ago

David Patrick on 2013-09-28T15:22:46Z says:

is this not already working fine as keybind "c" (change)? worksforme :)

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-09-28T15:50:10Z says:

David Patrick wrote:

is this not already working fine as keybind "c" (change)? worksforme :)

Yes, the functionality is the same. I was keeping this issue to remember to change 'c' to 'm'.

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-09-28T15:52:02Z says:

David Patrick wrote:

I like that line of thinking Scott, "modify" is sort of universal, powerful, and it's consistent with taskwarrior use. It might allow some kebinding decluttering too.. if hitting "m" resulted in a partially completed task command. As an example, suppose I was already looking at vit with a filter, and I hit "m" I would see

task proj:foo +tag modify >

from there it's easy-peasy to add/change/remove just about anything! description, project dates, whatever, and in a way that re-enforces CLI usage, and not as an alternative to it.

By the way, this can now be implemented with keybinds + %TASKARGS.

taskwarrior commented 6 years ago

Scott Kostyshak on 2013-09-28T15:52:42Z says:

Done at 75bea863.