search

vitabaks / postgresql_cluster

PostgreSQL High-Availability Cluster (based on Patroni). Automating with Ansible.
https://postgresql-cluster.org
MIT License
1.69k stars 411 forks source link

Revise ansible-lint to incorporate incremental changes for future adaptability #368

Closed ThomasSanson closed 1 year ago

ThomasSanson commented 1 year ago

The goal of this refactoring process would be to improve the maintainability and scalability of ansible-lint, making it easier to adapt and expand in the future.

vitabaks commented 1 year ago

@ThomasSanson Thank you for your contribution!

Processing skip_list is something that has been demanding attention for a long time.

Please note that some PR is still open (under development). This means that the merging of this PR is possible only after the completion of the code change in other PRs.

ThomasSanson commented 1 year ago

@vitabaks

I completely understand your perspective, and I want to shed some light on the changes I made. The main focus of my modifications was to refactor the skip_list, aiming at better anticipating and facilitating future work on the project.

Although my changes may seem minor, they are essential to streamline and prepare the codebase for further improvements and modifications. However, I understand if you have concerns regarding the potential impact of these changes on other aspects of the project.

If you wish, I can quickly carry out tests to assess the impacts of my modifications on other pull requests. My intention is to contribute positively to the project, ensuring my changes align well with existing and forthcoming work.

vitabaks commented 1 year ago

I understood you. Let me know if I need to merge into the master branch.

ThomasSanson commented 1 year ago

@vitabaks

✔️ The merge between this branch and the pg_upgrade branch is ok (testing)

this pull request is ready for me