search

vitabaks / postgresql_cluster

PostgreSQL High-Availability Cluster (based on "Patroni" and DCS "etcd" or "consul"). Automating with Ansible.
MIT License
1.27k stars 340 forks source link

Oracle Foreign Data Wrapper plugin #592

Open emccormickva opened 1 month ago

emccormickva commented 1 month ago

Hi all,

I recently had a client request to install the Oracle FDW plugin on their Postgresql cluster which is deployed and maintained with this wonderful set of playbooks. I wrote a playbook to handle this for them and merged it into their local fork of this repo.

Currently, it only supports EL9 and Oracle Instantclient 19.19 as that is what the customer is running, but is otherwise using and extending variables and structure already in tree here. If I were to extend it to support all of the other distros / versions supported here and add some variables for users to configure oracle client versions, would this be of interest to anyone? I'm not sure how much of an edge case this is, so I wanted to ask before putting the work in.

Cheers, Erik

vitabaks commented 1 month ago

Hi @emccormickva

I think it makes sense, but it should be an option and not a default setting. See an example of how I implement this for a future version ("Extension Auto-Setup") - https://github.com/vitabaks/postgresql_cluster/pull/464

example of a variable name: enable_oracle_fdw

emccormickva commented 1 month ago

Great. I'll work on cleaning it up and extending it to other distros. I did set it up as optional from the start

roles:

I'll switch it to "enable_oracle_fdw" for consistency.

vitabaks commented 1 month ago

I chose enable instead of install because we not only install packages, but also automatically prepare the configuration if necessary.