vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

Fix for non-working form submit #387

Closed lu4 closed 7 years ago

lu4 commented 8 years ago

When xeditable is placed into custom directive like:

        <tabset>
            <tab ng-repeat="(documentTemplateVid, documentTemplateV) in documentTemplateR.versions track by documentTemplateVid">
                <tab-heading>
                    <a href="#" editable-text="documentTemplateV.title">{{ documentTemplateR.title || "Title absent" }}</a>
                </tab-heading>
                <div class="row">
                    <div class="col-xs-12">
                        <div summernote ng-model="documentTemplateV.content">
                        </div>
                        <div class="text-right">
                            <button type="button" class="btn btn-primary" ng-click="">Save</button>
                            <button type="button" class="btn btn-primary" ng-click="">Cancel</button>
                        </div>
                    </div>
                </div>
            </tab>
        </tabset>

xeditable stops working because <button type="submit" > wont fire submit event

ckosloski commented 8 years ago

This change breaks many tests because the tests specifically look for a submit button to click. Fix the tests and don't submit the dist files with your request.

ckosloski commented 7 years ago

@lu4 can you update your request?

lu4 commented 7 years ago

Not sure that I remember what it had to do with the project, afaik there's no reason to make the fix since angular-xeditable is targeted at Angular 1 rather than 2, no new projects start with Angular 1 so nobody will ever need the fix, sorry... (((

ckosloski commented 7 years ago

ok, do you want to close this request then?

lu4 commented 7 years ago

Yeah, I'll do it