Added uib- Prefixes for angular-ui-bootstrap

vitalets / angular-xeditable

Edit in place for AngularJS

http://vitalets.github.io/angular-xeditable

MIT License

1.91k stars 403 forks source link

Added uib- Prefixes for angular-ui-bootstrap #406

Closed mhennemeyer closed 8 years ago

ckosloski commented 8 years ago

SylTi commented 8 years ago

typeahead also depend on ui-bootstrap

ymhuang0808 commented 8 years ago

May the pull request be merged? Perhaps, there are some indentation problems.

ckosloski commented 8 years ago

What needs to be done to get this merged?

eugef commented 8 years ago

Hi @ckosloski , please rebase your branch against the latest master and resolve the conflicts.

ymhuang0808 commented 8 years ago

Should the PR be resolved by @mhennemeyer ?

mitcht commented 8 years ago

What do all the CSS changes do? Are they needed? Is there a way to do without them? I don't want a version change to affect how the directives look when people upgrade.

mitcht commented 8 years ago

Also like @eugef said, fix the conflicts.

ymhuang0808 commented 8 years ago

It seems like that the CSS was only formatted.