vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

isDefaultPrevented check in editableForm prevents blur when it should occur #415

Closed mgerring closed 8 years ago

mgerring commented 8 years ago

There's a check in the document click handler for editableForm that prevents the form from being cancelled in many cases where it should be -- for example, clicking links using ui-sref from angular ui router, or opening modals in angular ui bootstrap.

In these cases the default behavior of a link is prevented, but form blur still takes place as expected. The editable form is actually blurred and should be cancelled, but the x-editable code bails out anyway because preventDefault was called on the link.

414 fixes the issue.

eugef commented 8 years ago

Fixed by #414