vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

ui-boostrap 1.1.2 and xeditable 0.1.9 Datepicker not popup #428

Closed msenthu closed 8 years ago

msenthu commented 8 years ago

All,

I am using angular 1.4.8, ui-boostrap 1.1.2 and xeditable 0.1.9, The Datepicker is not popup. Can you help me resolve this issue?

Thanks, Senthil

ckosloski commented 8 years ago

The ui-bootstrap tags need to be updated to use "uib". See pull request #406

msenthu commented 8 years ago

Thanks for the solution that worked, but still I am getting lot of console errors like below

TypeError: ngModelCtrl.$setValidity is not a function

Error: [$compile:ctreq] Controller 'ngModel', required by directive 'uibDatepicker', can't be found!

But I do have ng-Model/ e-ng-model that didnt help resolve the error. Also it is not using the format I specified. Any idea?

e-uib-datepicker-popup="yyyy-MMM-dd"

ckosloski commented 8 years ago

Your definition should be: data-e-datepicker-popup="yyyy-MMM-dd"

msenthu commented 8 years ago

Thanks for the quick reply, Here is my code i tried different options but both didn't work

<a href="#"  ng-model="lastReviewed" editable-bsdate="lastReviewed" data-e-datepicker-popup="yyyy-MMM-dd"
       e-ng-click="opened = true" e-is-open="opened"       >
        {{ (lastReviewed | date: "yyyy-MMM-dd") || 'Not reviewed' }}
</a>

Above code I am not getting the datapicker popup

and

<a href="#"  ng-model="lastReviewed" editable-bsdate="lastReviewed" data-e-uib-datepicker-popup="yyyy-MMM-dd" data-e-datepicker-popup="yyyy-MMM-dd"
       e-ng-click="opened = true" e-is-open="opened"       >
        {{ (lastReviewed | date: "yyyy-MMM-dd") || 'Not reviewed' }}
</a>

in the above code I get the datepicker popup but format is different (screen shot below). I would like the date appear as yyyy-MMM-dd format

image

ckosloski commented 8 years ago

You need to remove: data-e-uib-datepicker-popup="yyyy-MMM-dd"

You should only have: data-e-datepicker-popup="yyyy-MMM-dd"

msenthu commented 8 years ago

If i downgrade my angularjs-xeditable to 0.1.8 then it works as expected. It is not working on 0.1.9 and 0.1.10.

Thanks

eugef commented 8 years ago

Fixed by #443