vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

IE 11: When activationEvent is set to focus, on click event x-editable element blurs out. #465

Closed himmittal closed 5 years ago

himmittal commented 8 years ago

In IE 11, when activationEvent is set to focus, on click event x-editable element blurs out.

Can we have multiple activationEvent to enable edit mode through events like focus and click. Both would enable edit mode.

himmittal commented 8 years ago

Another Issue I found is that when I have editable-select element and any value is selected from drop down it loses its focus and therefore user navigating from keyboard has to tab through all the items again.

ckosloski commented 8 years ago

Do you have a jsfiddle or plunker showing this issue?

jjreicher commented 7 years ago

Running into the same issue...seems like not much activity here...

ckosloski commented 7 years ago

Do you have a plnkr/jsfiddle showing your issue? This will help others investigate your issue.

I have a Mac, so not easy for me to test with IE11.

jjreicher commented 7 years ago

http://plnkr.co/edit/Mn4vnP9vYS9eFiWhaNYQ?p=preview

Works in Chrome. Doesn't work in IE11.

ckosloski commented 7 years ago

I couldn't get the plnkr site to load in IE11 ☹️

jjreicher commented 7 years ago

Well it's pretty simple anyways. Basically loads up fine. Then when you click on the item, it ONLY remains in the editable state while actively holding down the mouse-click. As soon as you let up on the mouse-click, it reverts to text state.

pic1 pic2

allisonshaw commented 5 years ago

This seems to be a problem in Chrome now too with a recent Chrome update...

http://jsfiddle.net/L4jnp28a/5/

Expected results: enter edit mode via 'click' or 'focus' (tabbing to element) Actual results: When clicking, edit mode is active only as long as mouse is down. A single click opens then closes edit mode immediately.

jjreicher commented 5 years ago

I see it too in Chrome now. Hack solution has been to instruct users to right-click first, then type in the field. But would obviously be better to have a fix.

On Tue, Aug 20, 2019, 1:21 PM Allison Shaw notifications@github.com wrote:

This seems to be a problem in Chrome now too with a recent Chrome update...

http://jsfiddle.net/L4jnp28a/5/

Expected results: enter edit mode via 'click' or 'focus' (tabbing to element) Actual results: When clicking, edit mode is active only as long as mouse is down. A single click opens then closes edit mode immediately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vitalets/angular-xeditable/issues/465?email_source=notifications&email_token=ADF3RFMJ7MPFGRTM3C4VSL3QFRG37A5CNFSM4CCCNQUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4XRH3A#issuecomment-523178988, or mute the thread https://github.com/notifications/unsubscribe-auth/ADF3RFM7GM27MWZEEAOVYF3QFRG37ANCNFSM4CCCNQUA .