Added title and aria-label to form buttons

vitalets / angular-xeditable

Edit in place for AngularJS

http://vitalets.github.io/angular-xeditable

MIT License

1.91k stars 403 forks source link

Added title and aria-label to form buttons #537

Closed ckosloski closed 8 years ago

ckosloski commented 8 years ago

Add title to form buttons
Add aria-label to form buttons
Add configuration to display reset button
Fix bstime css issue
Add support for simple bootstrap input groups
Closes #341

eugef commented 8 years ago

Thanks @ckosloski

ckosloski commented 8 years ago

@eugef would it be possible to push out another release? I would like to get the css changes I made in the last to pull requests pushed out.

eugef commented 8 years ago

@ckosloski new release is out

letmejustfixthat commented 7 years ago

How does this close #341? I can't find anything how to add custom buttons to the panel. Or did you just implement the actual use case described in #341?

ckosloski commented 7 years ago

There was nothing in that ticket about custom buttons solutions, I implemented the items listed in the issue.

Point 1 - configuration to add a clear button was added.
Point 2 - Title and aria-labels were added to the buttons
Point 3 - Support was added for simple bootstrap input groups
Point 4 - Skipped, not entirely sure what solution he was looking for there and no other comments in over a year.

letmejustfixthat commented 7 years ago

I want to be able to add my own button to the Save/Cancel set, e.g. a clear button

I'm trying to add a button to completely remove the editable item from the model and hoped I just missed how to do that. But I guess that's not possible (without changes in the xeditable lib)?