search

vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

editableOptions.activate = 'select' should fallback on focus when element has no select #547

Closed Carnid closed 8 years ago

Carnid commented 8 years ago

https://github.com/vitalets/angular-xeditable/blob/master/src/js/editable-element/controller.js#L419

If element has no select() function, it should fall back to focus(). A common example is editable-select, which doesn't have a select() method and is no longer focused on activate.

Demo: http://jsfiddle.net/NfPcH/16911/

ckosloski commented 8 years ago

Please open a pull request.

Carnid commented 8 years ago

Here you go, not sure how to link issues with pull requests... https://github.com/vitalets/angular-xeditable/pull/548

ckosloski commented 8 years ago

What I do is usually just mention the issue that the pull request is for.