uneven typeahead results margin

pratheekhegde commented 8 years ago

Typeahead results have lots of margin in the top and bottom. It looks ugly. Playing with margin-top and margin-bottom of uib-typeahead-match class fixes it.

You can see it in the demo page .

I don't know if it is something to do with my markup or problem with x-editable.

Here is my markup

<span e-placeholder="Type your city" 
    data-e-form="editableForm" 
    editable-text="vm.profile.currentCity" 
    e-uib-typeahead="address for address in vm.getLocation($viewValue) | limitTo:8" 
    e-typeahead-loading="vm.loadingLocations" 
    e-typeahead-no-results="vm.noResults">
    {{ vm.profile.currentCity || 'empty' }}
</span>
<i ng-show="vm.loadingLocations" class="glyphicon glyphicon-refresh"></i>
 <div ng-show="vm.noResults">
    <i class="glyphicon glyphicon-remove"></i> No Results Found
 </div>

ckosloski commented 8 years ago

fixed in pr #544

pratheekhegde commented 8 years ago

I'm using the latest, it still seems to be there. 😕

white-space: nowrap; is white-space: pre; <= this is the prime reason.

Thanks @ckosloski for pointing me out to #544

BenevidesLecontes commented 8 years ago

@pratheekhegde white-space: normal; on editable-wrap, should fix.

pratheekhegde commented 8 years ago

@BenevidesLecontes That does fix ! 😃 . But, I dont see

/* fix padding issue on typeahead */
 .editable-text {
     white-space: nowrap;
 }

of #544 in https://github.com/vitalets/angular-xeditable/blob/master/dist/css/xeditable.css

ckosloski commented 8 years ago

It's merged, but not yet built. You would have to download the code and build yourself to get the latest changes.

pratheekhegde commented 8 years ago

Yea, I figured that out. Thanks again @ckosloski .

vitalets / angular-xeditable

uneven typeahead results margin #550