vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

editable-ui-select names must be unique across the application #551

Closed roblperry closed 8 years ago

roblperry commented 8 years ago

The storage of the match and choices elements in arrays in src/js/directives/uiselect.js, using the name attribute as an index, allows for conflicts in which the ui-select is rendered with the wrong match and choices. This can quickly become a major issue on large single page applications, especially when one is using the naming convention to associate server side validation errors with the proper field.

Some examples of this coming into play are:

It is possible to make naming make naming conventions more complicated in the application code to work around this issue, however this is onerous, especially when extra code for validation is required.