search

vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

datepicker-append-to-body directive now matches uib-datepicker #576

Closed Carnid closed 7 years ago

Carnid commented 7 years ago

uib-datepicker-popup directive for append to body is datepicker-append-to-body. It is expected when putting e-datepicker-append-to-body in an editable-bsdate that it would work. However, we have to enter e-date-picker-append-to-body and there is no mention of this in your documentation. This makes your editable-bsdate match uib-datepicker-popup documentation while still being retro-compatible.

eugef commented 7 years ago

@Carnid, thanks for the PR. Could you please update tests for the uib-datepicker-popup

ckosloski commented 7 years ago

@eugef this can be closed. This was fixed with #623