search

vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

Added possibility to set icon_set via attribute #587

Closed B3nCr closed 7 years ago

B3nCr commented 7 years ago

Also fixed icon_set value if theme is set via the attribute Tests added to dev-theme to test for both the fix and the enhancement Also made the dev-test run dev-theme and added some CSS to scripts-dev.jade to make the differences in themes apparent (only visible, the tests work the same with or without the css).

eugef commented 7 years ago

@B3nCr did you close PR on purpose?

B3nCr commented 7 years ago

Yes. I was trying to pull from the original source into my branch.

On 6 Dec 2016 08:32, "Eugene Fidelin" notifications@github.com wrote:

@B3nCr https://github.com/B3nCr did you close PR on purpose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vitalets/angular-xeditable/pull/587#issuecomment-265090692, or mute the thread https://github.com/notifications/unsubscribe-auth/ABN9VFy6c67svOnUsyMBuEHyT2Faydkiks5rFR1_gaJpZM4LFIFe .