vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

e-maxlength allow to add one charachter #612

Open moshfeu opened 7 years ago

moshfeu commented 7 years ago

The steps:

  1. Double click on the label.
  2. Type one character.

Expected result:

You can't.

Actual result

You can add the one. If you delete it you can't add anymore until you will close the field and double click on it again. The problem of course if the model is with the maximum allowed length.

Note: If you save it, it saved the old value, but it's not good in the UI. Note2: It only occurs when I'm using ng-dblclick click. If I set the event to ng-click everything works fine.

http://jsbin.com/puzage/edit?html,output

Thanks!

ckosloski commented 7 years ago

Can you provide a link to the issue you are having?

moshfeu commented 7 years ago

Sure.. It was in the bin, but apparently I changed it back to ng-click. I save a snapshot for this here: http://jsbin.com/puzage/2/edit?html,js,output

ckosloski commented 7 years ago

I'm not understanding the issue.

What exactly is the issue?

moshfeu commented 7 years ago

Try adding new character, can't because of max length - Well, I can.

See the screen record: https://drive.google.com/open?id=0By_6v7nVfuvmSDMwWjhmdVRzSDg

You can see in the video that although the input's value is already the maxlength I can type one more character. When I delete it I can't type anymore.

ckosloski commented 7 years ago

This only seems to be an issue on Chrome.