search

vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 403 forks source link

Fix editable-combodate for single date fields #709

Closed ckosloski closed 6 years ago

ckosloski commented 6 years ago
ckosloski commented 6 years ago

@josemonsalve2 please review

josemonsalve2 commented 6 years ago

It looks good to me

josemonsalve2 commented 6 years ago

Also, thanks for being so responsive

eugef commented 6 years ago

@ckosloski you are using moment.js, but it only a devDependency of the angular-xeditble. I think me should mention in the documentation that for editable-combodate you need a moment.js installed as a global variable

ckosloski commented 6 years ago

@eugef the documentation already states you need moment.js for combodate

josemonsalve2 commented 6 years ago

@ckosloski is right. I felt free to use moment.js due to the mention in the documentation.