vitalets / angular-xeditable

Edit in place for AngularJS
http://vitalets.github.io/angular-xeditable
MIT License
1.91k stars 402 forks source link

Does editable-checklist support e-name? #769

Closed sinall closed 4 years ago

sinall commented 4 years ago

When one of checkbox is checked, I want some other elements to show or hide. So I plan to use editableForm['some-name']['$viewValue'], but this is undefined. I checked the html, but it seems that name is not added onto input.

ckosloski commented 4 years ago

Did you try data-e-name="some-name" when you defined the checkbox?

sinall commented 4 years ago

@ckosloski I made an example on jsfiddle, but the input element still doesn't have a name: <input type="checkbox" checklist-value="s.value" ng-model="checked" class="ng-scope ng-pristine ng-valid ng-not-empty ng-touched" checklist-model="$parent.$parent.$data">

Ideally, the input should have name="check_list[]" in order to hold multiple values as this thread described.

ckosloski commented 4 years ago

OK, I think I see the issue. I'll see if I can come up with a fix.

ckosloski commented 4 years ago

I've created a PR for this, please review.