search

vitalets / checklist-model

AngularJS directive for list of checkboxes
http://vitalets.github.io/checklist-model
MIT License
1.05k stars 207 forks source link

add support for commonjs #132

Closed phillipgreenii closed 8 years ago

phillipgreenii commented 8 years ago

This patch will allow tools like browserify to import checklist-model when pulled from npm.

beradrian commented 8 years ago

Doesn't work currently for you to import it from browserify? It works fine for me.

phillipgreenii commented 8 years ago

The convention I have found with angular plugins is that they export the name of the angular module so that they can be used in a similar fashion of 

angular.module('mymodule', [
  require('checklist-model')
]);
beradrian commented 8 years ago

I merged your PR. It will be included in the next release. Thank you.

phillipgreenii commented 8 years ago

Awesome! Thank you!

On Tue, May 10, 2016 at 2:26 AM, Adrian Ber notifications@github.com wrote:

I merged your PR. It will be included in the next release. Thank you.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/vitalets/checklist-model/pull/132#issuecomment-218069691