search

vitalets / checklist-model

AngularJS directive for list of checkboxes
http://vitalets.github.io/checklist-model
MIT License
1.05k stars 207 forks source link

fix(package.json) Move AngularJS as a `peerDependency` #166

Closed erickwilder closed 6 years ago

erickwilder commented 6 years ago

AngularJS is now a peerDependency and it has to be installed separately. This is a breaking change, so the package.json version was bumped to a 1.0.0.

Rationale

The default NPM dependency resolution usually works just fine with the explicit dependency, but it also introduce some weird behaviors, like allowing two versions of the same library to co-exist. Since it is generally a bad idea to have two concurrent AngularJS versions installed, turning it into a peerDependency makes more sense and give the user of this library all control over AngularJS installation.

https://nodejs.org/en/blog/npm/peer-dependencies/

erickwilder commented 6 years ago

@vitalets - Is this project still alive?

vitalets commented 6 years ago

@erickwilder thanks for the PR.

Let's ping collaborators: @sazo @beradrian are you still have time to maintain checklist-model?

erickwilder commented 6 years ago

@sazo @beradrian @vitalets

Can we move on with this PR? If you don't have enough time to maintain it I suggest adding a disclaimer on the main project README about it.

vitalets commented 6 years ago

Hi @erickwilder !

Agree, I will merge it. Btw, shouldn't we restrict upper angular version?

erickwilder commented 6 years ago

I don't think it's necessary. I'm still using the library with latest AngularJS (1.6) series and the newer (Angular 2+) don't share the same package name on npm