search

vitalets / google-translate-api

A free and unlimited API for Google Translate :dollar: :no_entry_sign:
MIT License
941 stars 120 forks source link

XO Updated #47

Closed ZyC0R3 closed 1 year ago

ZyC0R3 commented 4 years ago

XO has been updated from the version this API is currently using 0.16.0 to 0.28.1

in V0.18.0 it added in 21 new rules: (https://github.com/xojs/xo/releases/tag/v0.18.0) Unicorn plugin: sindresorhus/eslint-plugin-unicorn@v1.0.0...v2.1.0 no-array-instanceof no-new-buffer no-hex-escape number-literal-case escape-case prefer-starts-ends-with custom-error-definition type-error AVA plugin: avajs/eslint-plugin-ava@a0156f1 no-async-fn-without-await no-duplicate-modifiers

When you update this dependency to 0.28.0 or even past 0.17.0 it breaks the testing in travis, but the api still works in the deployment i use, is there anyway you will be able to update the XO Dependancy and the test to use the latest version.

vitalets commented 4 years ago

could you make a PR with latest XO version and make tests passing?

ZyC0R3 commented 4 years ago

I can not seem to fix this issue or get the tests to pass. Are you able to fix this.

vitalets commented 1 year ago

In new release v9 XO was replaced with eslint.