vitalets / x-editable

In-place editing with Twitter Bootstrap, jQuery UI or pure jQuery

http://vitalets.github.io/x-editable

MIT License

6.51k stars 1.72k forks source link

Add support for Bootstrap4 #1071

Open Talv opened 6 years ago

Talv commented 6 years ago

I couldn't get the test-suite working in cli for bs4. Tested via browser. [common] 8. container's title and placement from json options failed because css for bootstrap is not being loaded for some reason.

Other than that it's alright. Some units related to datepicker and select2 failing, but they fail for bs3 aswell, so.. ¯_(ツ)_/¯.

1043 #950

lenormf commented 6 years ago

Was support for the datepicker added?

Talv commented 6 years ago

I did not test by myself (and test units are kind of broken in general), but it's likely that it works - as well as it did for bs3. If however datepicker needed some adjustments for bs4, then these are not present in this PR.

lenormf commented 6 years ago

Datepickers are not implemented for bootstrap3 (for some reason), maybe now is a good time to bridge the gap? Combodates are really aesthetically unpleasing.

divdax commented 6 years ago

Any news on this? 😄

It needs some more tweaks. Bootstrap 4 is using Popper.js instead of Tether. The Popover position is right by default and should be top?

ilramdhan commented 1 month ago

For those of you who are struggling to implement it on Bootstrap 4, maybe this can help.

For Bootstrap 4 its work, check this https://github.com/vitalets/x-editable/issues/1189#issue-2472436889