search

vitalets / x-editable

In-place editing with Twitter Bootstrap, jQuery UI or pure jQuery
http://vitalets.github.io/x-editable
MIT License
6.51k stars 1.72k forks source link

Notable changes in Bootstrap 3 #318

Open hallister opened 11 years ago

hallister commented 11 years ago

Here are some notable changes given the current Bootstrap3:

Given the major changes between versions it might be prudent to make a separate build for Bootstrap 3. I've got x-editable running on BS 3, but that required adding containerDataName: 'bs.tooltip' and several changes to the bootstrap template (additional button class, removing input-size classes and adding form-control class).

I can clean up my changes and PR them, but I'm not really sure if going with an entirely separate module is the best method. Especially given the editable-popover.js would have a total of 2 or 3 lines different.

bmrpatel commented 11 years ago

Can you share your fix and I can try it out?

Thanks

lruckman commented 11 years ago

I don't really know what's best but if you could post somewhere I'm sure others, like myself would find it most helpful.

hallister commented 11 years ago

I still have some work to do but as soon as my modifications are done I'll branch it in my repo and update this. Hopefully I'll have this done tomorrow.

brainwirelabs commented 11 years ago

I'm having trouble implementing some of your fixes for BS 3. Most notably: containerName is no longer "popover" it's now "bs.popover".

When I click on the element to edit I get the exception: "Error: bs.popover not found. Have you included corresponding js file?"

I second the request for your fixes. I would love to get this working on BS 3 as I'm sure others would as well.

vitalets commented 11 years ago

@hall5714 big thanks for that! didn't have time to look into BS3. To keep compability maybe we can add new container bs-popover..

hallister commented 11 years ago

Yeah I never posted my fix because it only happened to work with the stack I was using (AngularJS + AngularStrap). I'm guessing that's mostly an issue with the template rather than the code. I'd take a closer look but I've been going nuts lately trying to get AngularUI to work with B.S. 3 :P.

koppor commented 11 years ago

Possibly the Bootstrap 3 Migration Guide will get updated these days. BTW, it also says that Bootstrap 3 will be released "around August 19".

aronchick commented 11 years ago

Did this get fixed? It's not working on my Bootstrap 3.