vitalets / x-editable

In-place editing with Twitter Bootstrap, jQuery UI or pure jQuery
http://vitalets.github.io/x-editable
MIT License
6.51k stars 1.72k forks source link

Orientation of typeahead and datepicker editors #407

Open ghost opened 11 years ago

ghost commented 11 years ago

I have both a typeahead and a datepicker editor at the bottom of a page. When I edit the values the suggestions and date selection popups go off the bottom of the page requiring the user to scroll down. It would be good if they could auto orientate themselves so that they would popup above if needed.

Is it possible to control the orientation of the typeahead and datepicker editors?

vitalets commented 10 years ago

@benshort you should check it in bootstrap typeahead docs and datepicker docs If such option exists, you can pass it through x-editable to original plugin.

ghost commented 10 years ago

@vitalets The documentation http://vitalets.github.io/x-editable/docs.html#date points to this http://vitalets.github.io/bootstrap-datepicker/ datepicker which doesn't detail an orientation option. I'm using x-editable 1.4.5 does the 1.5.0 release use the datepicker your specified?

vladar commented 10 years ago

The "orientation" option exists in latest bootstrap-datepicker (1.2, released a couple months ago), but looks like you include older version of this plugin in x-editable. Can you consider upgrading to latest version for 1.5.1?

Also, as far as I understand, original datepicker now has inline mode, so there is no need to ship it with x-editable build, is it correct? It's just not convenient to deal with this plugin when it is a part of x-editable.

vitalets commented 10 years ago

oh, there was incorrect link in documenation. Will update it. Considering not shipping bootstrap-datepicker with x-editable - it's good idea, I thought about it. I planned to make custom builder so anyone can get customized build with or without datepicker and other components. But no time for that.., so may be just remove it from default build in 1.6.

cuongle commented 10 years ago

Thanks for this thread, is there any roadmap (ETA) for 1.6 release?