vitalif / grive2

Google Drive client with support for new Drive REST API and partial sync
http://yourcmc.ru/wiki/Grive2
GNU General Public License v2.0
1.52k stars 140 forks source link

grive-sync.sh is not uploading detected changes. #231

Closed tsiegleauq closed 5 years ago

tsiegleauq commented 6 years ago

Detecting changes using systemctl --user start grive-changes@$(systemd-escape google-drive).service works. However, uploading them works not.

systemctl --user status grive-changes@$(systemd-escape google-drive).service Will inform you that:

grive-sync.sh[10574]: Listening for changes in ~/google-drive/
grive-sync.sh[10574]: Need a directory name in the current users home directory as second argument. Aborting.

therefore, no changes are being made.

Reproduce:

jankatins commented 5 years ago

My guess is that this is because the unescape happens twice in that case: it's started with the escaped version, the listens to the changes, but the call to sync then uses a unescaped version of the filename.

λ systemd-escape --unescape $(systemd-escape --unescape $(systemd-escape grive-test))
grive/test
jankatins commented 5 years ago

Please see https://github.com/vitalif/grive2/pull/244 for a potential fix