search

vitalif / grive2

Google Drive client with support for new Drive REST API and partial sync
http://yourcmc.ru/wiki/Grive2
GNU General Public License v2.0
1.52k stars 140 forks source link

Suggestion: upload multiple files at once #329

Open developomp opened 4 years ago

developomp commented 4 years ago

Currently, grive appears to upload files one at a time and the next file in line has to wait until the previous one is uploaded. Make grive be able to upload multiple files at once and add a setting for how many files it can upload simultaneously (4 sounds like a reasonable default amount).

rautamiekka commented 4 years ago

I wonder if that's even possible. Even the official Window$ Client works on single file basis whatever it does.

Tatsh commented 4 years ago

It's possible, but Google probably won't like it. They will probably throttle.

I don't think this is a good idea as even if Google didn't do anything on their end, Grive is set up to send 1 file at a time without a speed limit (unless you specify one), and Google accepts Google Drive files at a speed higher than most US ISPs allow for upload (I'm looking at you Comcast). Basically, for most people, Grive is going fast as it can and sending multiple files at once won't make a difference. It also is much more error-prone.

kgrewal2 commented 3 years ago

Well, we can actually create a queue of multiple files that user wants to send to google drive. Then we send the files one by one, with a delay between each file so that Google doesn't see it as wrong or fishy activity.

Tatsh commented 3 years ago

They are not going to see it as fishy if it's just your own account under OAuth with your own app. They will still throttle. https://developers.google.com/drive/api/v3/handle-errors#resolve_a_403_error_daily_limit_exceeded

It wouldn't be such a bad idea to implement checking for daily limit and avoiding going over.