vitalif / vitastor

Simplified distributed block and file storage with strong consistency, like in Ceph (repository mirror)
https://vitastor.io
Other
140 stars 22 forks source link

Is there a libvirt patch for vitastor #7

Closed lnsyyj closed 3 years ago

lnsyyj commented 3 years ago

Hi Vitaliy, I want to use the virsh command to manage virtual machines through libvirt, but libvirt does not support vitastor, is there a corresponding patch?

root@vitastor-test:~# virsh  define vm_win10
error: Failed to define domain from vm_win10
error: unsupported configuration: unknown protocol type 'vitastor'
vitalif commented 3 years ago

Hi, no, I haven't tried libvirt. I thought libvirt didn't require patches... It's a pity if it requires patching too :-) Is it possible to create a volume by hand and then just pass a qemu option with an unknown driver through libvirt?

vitalif commented 3 years ago

Hi, I made a patch for libvirt. Check it out here https://github.com/vitalif/vitastor/tree/master/cinder-driver :-)

lnsyyj commented 3 years ago

@vitalif thank you!

lnsyyj commented 3 years ago

@vitalif I use debian 11, libvirt 7.0.0 into patch, the following error occurred when compiling deb.

I use libvirt released by Debian, and use the following method to get the source code apt-get source libvirt, and the deb can be compiled before adding patch.

Can you take a look, thank you very much.

[357/1251] cc -Isrc/conf/libvirt_conf.a.p -Isrc/conf -I../../src/conf -Isrc/util -I../../src/util -Iinclude -I../../include -Isrc -I../../src -I. -I../.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libxml2 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -Werror -fno-common -W -Wabsolute-value -Waddress -Waddress-of-packed-member -Waggressive-loop-optimizations -Wall -Wattribute-warning -Wattributes -Wbool-compare -Wbool-operation -Wbuiltin-declaration-mismatch -Wbuiltin-macro-redefined -Wcannot-profile -Wcast-align -Wcast-align=strict -Wcast-function-type -Wchar-subscripts -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time -Wdeclaration-after-statement -Wdeprecated-declarations -Wdesignated-init -Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero -Wduplicated-cond -Wduplicate-decl-specifier -Wempty-body -Wendif-labels -Wexpansion-to-defined -Wextra -Wformat-contains-nul -Wformat-extra-args -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wformat-zero-length -Wframe-address -Wfree-nonheap-object -Whsa -Wif-not-aligned -Wignored-attributes -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types -Winit-self -Winline -Wint-conversion -Wint-in-bool-context -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wlogical-not-parentheses -Wlogical-op -Wmain -Wmaybe-uninitialized -Wmemset-elt-size -Wmemset-transposed-args -Wmisleading-indentation -Wmissing-attributes -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-profile -Wmissing-prototypes -Wmultichar -Wmultistatement-macros -Wnarrowing -Wnested-externs -Wnonnull -Wnonnull-compare -Wnull-dereference -Wodr -Wold-style-declaration -Wold-style-definition -Wopenmp-simd -Woverflow -Woverride-init -Wpacked-bitfield-compat -Wpacked-not-aligned -Wparentheses -Wpointer-arith -Wpointer-compare -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wpsabi -Wrestrict -Wreturn-local-addr -Wreturn-type -Wscalar-storage-order -Wsequence-point -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wsizeof-array-argument -Wsizeof-pointer-div -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wstringop-truncation -Wsuggest-attribute=cold -Wsuggest-attribute=const -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-attribute=pure -Wsuggest-final-methods -Wsuggest-final-types -Wswitch -Wswitch-bool -Wswitch-unreachable -Wsync-nand -Wtautological-compare -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvarargs -Wvariadic-macros -Wvector-operation-performance -Wvla -Wvolatile-register-var -Wwrite-strings -Walloc-size-larger-than=9223372036854775807 -Warray-bounds=2 -Wattribute-alias=2 -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wnormalized=nfc -Wshift-overflow=2 -Wstringop-overflow=2 -Wunused-const-variable=2 -Wno-sign-compare -Wno-cast-function-type -Wjump-misses-init -Wswitch-enum -Wno-format-nonliteral -Wno-format-truncation -Wframe-larger-than=4096 -fexceptions -fasynchronous-unwind-tables -fipa-pure-const -Wno-suggest-attribute=pure -Wno-suggest-attribute=const -fstack-protector-strong -Wdouble-promotion -g -O2 -ffile-prefix-map=/root/libvirtsource/libvirt-7.0.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DIN_LIBVIRT '-Dabs_top_builddir="/root/libvirtsource/libvirt-7.0.0/debian/build"' '-Dabs_top_srcdir="/root/libvirtsource/libvirt-7.0.0"' -MD -MQ src/conf/libvirt_conf.a.p/domain_conf.c.o -MF src/conf/libvirt_conf.a.p/domain_conf.c.o.d -o src/conf/libvirt_conf.a.p/domain_conf.c.o -c ../../src/conf/domain_conf.c
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd debian/build && LC_ALL=C.UTF-8 ninja -j48 -v returned exit code 1
make: *** [debian/rules:166: binary] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
vitalif commented 3 years ago

OK, fixed, these warnings were some 'value XXX_VITASTOR not handled in switch'. I fixed them in 5.0 and 7.5, but forgot about 7.0.

lnsyyj commented 3 years ago

Great, the previous problem has been solved. But some of libvirt's checks seem to have failed. Can you help me take a look?

170/327 libvirt:syntax-check / sc_avoid_write                                    FAIL           0.38s (exit status 2)

--- command ---
01:40:50 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_avoid_write
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
avoid_write
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Pass-GPG_TTY-env-var-to-the-ssh-binary.patch/src/rpc/virnetsocket.c:1651:    return write(sock->fd, buf, len);
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Pass-GPG_TTY-env-var-to-the-ssh-binary.patch/src/rpc/virnetsocket.c:1847:        ret = write(sock->fd, buf, len);
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: consider using safewrite instead of write
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:317: sc_avoid_write] Error 1
-------

186/327 libvirt:syntax-check / sc_prohibit_setuid                                FAIL           0.76s (exit status 2)

--- command ---
01:40:50 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_setuid
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_setuid
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:1018:    if (gid != (gid_t)-1 && setregid(gid, gid) < 0) {
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:1033:    if (uid != (uid_t)-1 && setreuid(uid, uid) < 0) {
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: use virSetUIDGID, not raw set*id
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:451: sc_prohibit_setuid] Error 1
-------

191/327 libvirt:syntax-check / sc_prohibit_gethostname                           FAIL           0.68s (exit status 2)

--- command ---
01:40:51 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_gethostname
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_gethostname
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:476: * 1)  gethostname() returns an FQDN (not localhost) - we return the string
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:478: * 2)  gethostname() returns "localhost" - we return localhost; doing further
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:480: * 3)  gethostname() returns a shortened hostname - in this case, we want to
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:485: *         data we got from gethostname() is actually more useful than what
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:486: *         we got from getaddrinfo().  Return the value from gethostname()
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: use virGetHostname, not gethostname
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:478: sc_prohibit_gethostname] Error 1
-------

203/327 libvirt:syntax-check / sc_TAB_in_indentation                             FAIL           0.47s (exit status 2)

--- command ---
01:40:51 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_TAB_in_indentation
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
TAB_in_indentation
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:29: unsigned i;
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:31: assert(code_map_osx_to_win32_len == ARRAY_SIZE(code_map_osx_to_win32));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:32: assert(code_map_osx_to_win32[0x1d] == 0x30);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:33: assert(name_map_osx_to_win32_len == ARRAY_SIZE(name_map_osx_to_win32));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:34: assert(strcmp(name_map_osx_to_win32[0x1d], "VK_0") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:36: assert(code_map_osx_to_xkb_len == ARRAY_SIZE(code_map_osx_to_xkb));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:37: assert(strcmp(code_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:38: assert(name_map_osx_to_xkb_len == ARRAY_SIZE(name_map_osx_to_xkb));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:39: assert(strcmp(name_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:41: assert(code_map_html_to_win32_len == ARRAY_SIZE(code_map_html_to_win32));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:42: for (i = 0;i < code_map_html_to_win32_len;i++) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:43:     if (strcmp(code_map_html_to_win32[i].from, "ControlLeft") == 0) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:44:         assert(code_map_html_to_win32[i].to == 0x11);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:45:         break;
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:46:     }
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:47: }
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:48: assert(i != code_map_html_to_win32_len);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:49: assert(name_map_html_to_win32_len == ARRAY_SIZE(name_map_html_to_win32));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:50: for (i = 0;i < name_map_html_to_win32_len;i++) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:51:     if (strcmp(name_map_html_to_win32[i].from, "ControlLeft") == 0) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:52:         assert(strcmp(name_map_html_to_win32[i].to, "VK_CONTROL") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:53:         break;
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:54:     }
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:55: }
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:56: assert(i != name_map_html_to_win32_len);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:58: assert(code_table_osx_len == ARRAY_SIZE(code_table_osx));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:59: assert(code_table_osx[0x1d] == 0x3b);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:60: assert(name_table_osx_len == ARRAY_SIZE(name_table_osx));
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:61: assert(strcmp(name_table_osx[0x1d], "Control") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:63: return 0;
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: indent with space, not TAB, in C, sh, html, py, syms and RNG schemas
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:556: sc_TAB_in_indentation] Error 1
-------

217/327 libvirt:syntax-check / sc_prohibit_int_ijk                               FAIL           0.82s (exit status 2)

--- command ---
01:40:51 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_int_ijk
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_int_ijk
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:29: unsigned i;
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: use size_t, not int/unsigned int for loop vars i, j, k
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:640: sc_prohibit_int_ijk] Error 1
-------

231/327 libvirt:syntax-check / sc_copyright_usage                                FAIL           0.56s (exit status 2)

--- command ---
01:40:51 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_copyright_usage
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
copyright_usage
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/LICENSE.GPL2:5: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/LICENSE.GPL2:308:    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: Point to <http://www.gnu.org/licenses/>, not an address
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:820: sc_copyright_usage] Error 1
-------

257/327 libvirt:syntax-check / sc_prohibit_sysconf_pagesize                      FAIL           0.65s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_sysconf_pagesize
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_sysconf_pagesize
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c:1556:    return sysconf(_SC_PAGESIZE);
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: use virGetSystemPageSize[KB] instead of sysconf(_SC_PAGESIZE)
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1054: sc_prohibit_sysconf_pagesize] Error 1
-------

262/327 libvirt:syntax-check / sc_gettext_init                                   FAIL           0.40s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_gettext_init
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
gettext_init
/root/libvirtsource/libvirt-7.0.0/.pc/forward/Skip-vircgrouptest.patch/tests/vircgrouptest.c
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: the above files do not call virGettextInitialize
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1084: sc_gettext_init] Error 1
-------

264/327 libvirt:syntax-check / sc_prohibit_http_urls                             FAIL           0.54s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_http_urls
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_http_urls
/root/libvirtsource/libvirt-7.0.0/debian/libvirt-daemon.NEWS:26:  http://libvirt.org/cgroups.html
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: Links must use https:// protocol
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1109: sc_prohibit_http_urls] Error 1
-------

265/327 libvirt:syntax-check / sc_prohibit_author                                FAIL           0.60s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_author
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_author
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/thirdparty/argparse.py:1:# Author: Steven J. Bethard <steven.bethard@gmail.com>.
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: Author: statements are prohibited in source comments
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1115: sc_prohibit_author] Error 1
-------

273/327 libvirt:syntax-check / sc_prohibit_strcmp                                FAIL           0.65s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_strcmp
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_strcmp
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc++.cc:28:  assert(strcmp(name_map_osx_to_win32[0x1d], "VK_0") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc++.cc:30:  assert(strcmp(code_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc++.cc:31:  assert(strcmp(name_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc++.cc:34:  assert(strcmp(name_map_html_to_win32.at("ControlLeft"), "VK_CONTROL") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc++.cc:37:  assert(strcmp(name_table_osx[0x1d], "Control") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:34: assert(strcmp(name_map_osx_to_win32[0x1d], "VK_0") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:37: assert(strcmp(code_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:39: assert(strcmp(name_map_osx_to_xkb[0x1d], "AE10") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:43:     if (strcmp(code_map_html_to_win32[i].from, "ControlLeft") == 0) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:51:     if (strcmp(name_map_html_to_win32[i].from, "ControlLeft") == 0) {
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:52:         assert(strcmp(name_map_html_to_win32[i].to, "VK_CONTROL") == 0);
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:61: assert(strcmp(name_table_osx[0x1d], "Control") == 0);
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: replace strcmp calls above with STREQ/STRNEQ
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1319: sc_prohibit_strcmp] Error 1
-------

279/327 libvirt:syntax-check / sc_require_config_h                               FAIL           0.34s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_require_config_h
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
require_config_h
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: the above files do not include <config.h>
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1378: sc_require_config_h] Error 1
-------

280/327 libvirt:syntax-check / sc_require_config_h_first                         FAIL           0.33s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_require_config_h_first
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
require_config_h_first
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: the above files include some other header before <config.h>
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1400: sc_require_config_h_first] Error 1
-------

307/327 libvirt:syntax-check / sc_trailing_blank                                 FAIL           0.70s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_trailing_blank
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
trailing_blank
/root/libvirtsource/libvirt-7.0.0/debian/changelog:336:    (Closes: #939552) 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/apparmor-let-image-label-setting-loop-over-backing-files.patch:26: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/apparmor-let-image-label-setting-loop-over-backing-files.patch:40: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/apparmor-let-image-label-setting-loop-over-backing-files.patch:50: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/apparmor-let-image-label-setting-loop-over-backing-files.patch:54: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/meson-Fix-cross-building-of-dtrace-probes.patch:37: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/meson-Fix-cross-building-of-dtrace-probes.patch:50: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/meson-Fix-cross-building-of-dtrace-probes.patch:58: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/meson-Fix-cross-building-of-dtrace-probes.patch:71: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/backport/meson-Fix-cross-building-of-dtrace-probes.patch:79: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:18: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:26: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:32: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:43: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:48: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:52: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:54: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:56: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:75: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirt-guests.patch:84: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirtd.patch:15: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-libvirtd.patch:31: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-systemd-service-files.patch:18: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-systemd-service-files.patch:31: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-systemd-service-files.patch:43: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Debianize-systemd-service-files.patch:57: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Set-defaults-for-zfs-tools.patch:25: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Use-sensible-editor-by-default.patch:15: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/Use-sensible-editor-by-default.patch:20: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/apparmor_profiles_local_include.patch:42: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/debian/apparmor_profiles_local_include.patch:51: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch:19: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch:23: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Skip-vircgrouptest.patch:16: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Skip-vircgrouptest.patch:18: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Skip-vircgrouptest.patch:21: 
/root/libvirtsource/libvirt-7.0.0/debian/patches/forward/Skip-vircgrouptest.patch:22: 
/root/libvirtsource/libvirt-7.0.0/debian/tests/smoke:10:virsh net-list 
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-bold-italic.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-bold.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-italic.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-light-italic.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-light.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-mono-bold.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-mono-light.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-mono-regular.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-mono-semibold.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/docs/fonts/overpass-regular.woff: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0000-00-01.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0000-00-02.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0000-00-03.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0000-01-00.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0000-02-00.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0001-00-00.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0001-01-00.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0001-01-00.1.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0005-80-00.0.config: binary file matches
grep: /root/libvirtsource/libvirt-7.0.0/tests/virpcitestdata/0005-90-01.2.config: binary file matches
build-aux/syntax-check.mk: found trailing blank(s)
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1608: sc_trailing_blank] Error 1
-------

312/327 libvirt:syntax-check / sc_prohibit_empty_lines_at_EOF                    FAIL           0.40s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_empty_lines_at_EOF
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_empty_lines_at_EOF
/root/libvirtsource/libvirt-7.0.0/debian/changelog
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/README
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/javascript
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/thirdparty/LICENSE-argparse.txt
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: empty line(s) or no newline at EOF
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1687: sc_prohibit_empty_lines_at_EOF] Error 1
-------

313/327 libvirt:syntax-check / sc_prohibit_doubled_word                          FAIL           1.50s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_prohibit_doubled_word
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
prohibit_doubled_word
/root/libvirtsource/libvirt-7.0.0/debian/changelog:4189:to to
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: doubled words
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1720: sc_prohibit_doubled_word] Error 1
-------

319/327 libvirt:syntax-check / sc_po_check                                       FAIL           0.40s (exit status 2)

--- command ---
01:40:52 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_po_check
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
po_check
--- /root/libvirtsource/libvirt-7.0.0/po/POTFILES.in
+++ /root/libvirtsource/libvirt-7.0.0/po/POTFILES.in
@@ -5,6 +5,11 @@
 @BUILDDIR@src/admin/admin_server_dispatch_stubs.h
 @BUILDDIR@src/remote/remote_client_bodies.h
 @BUILDDIR@src/remote/remote_daemon_dispatch_stubs.h
+@SRCDIR@.pc/backport/apparmor-let-image-label-setting-loop-over-backing-files.patch/src/security/security_apparmor.c
+@SRCDIR@.pc/debian/Debianize-libvirt-guests.patch/tools/libvirt-guests.sh.in
+@SRCDIR@.pc/debian/Use-sensible-editor-by-default.patch/tools/vsh.c
+@SRCDIR@.pc/forward/Pass-GPG_TTY-env-var-to-the-ssh-binary.patch/src/rpc/virnetsocket.c
+@SRCDIR@.pc/forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch/src/util/virutil.c
 @SRCDIR@src/access/viraccessdriverpolkit.c
 @SRCDIR@src/access/viraccessmanager.c
 @SRCDIR@src/admin/admin_server.c
@@ -85,6 +90,7 @@
 @SRCDIR@src/interface/interface_backend_netcf.c
 @SRCDIR@src/interface/interface_backend_udev.c
 @SRCDIR@src/internal.h
+@SRCDIR@src/keycodemapdb/thirdparty/argparse.py
 @SRCDIR@src/libvirt-domain-checkpoint.c
 @SRCDIR@src/libvirt-domain-snapshot.c
 @SRCDIR@src/libvirt-domain.c
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: you have changed the set of files with translatable diagnostics;
 apply the above patch
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1798: sc_po_check] Error 1
-------

323/327 libvirt:syntax-check / sc_spacing-check                                  FAIL           2.49s (exit status 2)

--- command ---
01:40:53 /usr/bin/make -C /root/libvirtsource/libvirt-7.0.0/debian/build/build-aux sc_spacing-check
--- stdout ---
make[2]: Entering directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
spacing-check
/root/libvirtsource/libvirt-7.0.0/build-aux/vc-list-files -C /root/libvirtsource/libvirt-7.0.0 | grep '\.c$' | xargs \
 /root/libvirtsource/libvirt-7.0.0/build-aux/check-spacing.pl || \
  { echo 'build-aux/syntax-check.mk: incorrect formatting' 1>&2; exit 1; }
Invalid character after semicolon:
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:42:     for (i = 0;i < code_map_html_to_win32_len;i++) {
Invalid character after semicolon:
/root/libvirtsource/libvirt-7.0.0/src/keycodemapdb/tests/stdc.c:50:     for (i = 0;i < name_map_html_to_win32_len;i++) {
make[2]: Leaving directory '/root/libvirtsource/libvirt-7.0.0/debian/build/build-aux'
--- stderr ---
build-aux/syntax-check.mk: incorrect formatting
make[2]: *** [/root/libvirtsource/libvirt-7.0.0/build-aux/syntax-check.mk:1852: sc_spacing-check] Error 1
-------

Summary of Failures:

 52/327 libvirt / vircgrouptest                                                  SKIP           0.17s
152/327 libvirt / virsh-checkpoint                                               SKIP           0.05s
156/327 libvirt / virsh-optparse                                                 SKIP           0.05s
157/327 libvirt / virsh-output                                                   SKIP           0.11s
162/327 libvirt / virsh-snapshot                                                 SKIP           0.18s
170/327 libvirt:syntax-check / sc_avoid_write                                    FAIL           0.38s (exit status 2)
170/327 libvirt:syntax-check / sc_avoid_write                                    FAIL           0.38s (exit status 2)
186/327 libvirt:syntax-check / sc_prohibit_setuid                                FAIL           0.76s (exit status 2)
186/327 libvirt:syntax-check / sc_prohibit_setuid                                FAIL           0.76s (exit status 2)
191/327 libvirt:syntax-check / sc_prohibit_gethostname                           FAIL           0.68s (exit status 2)
191/327 libvirt:syntax-check / sc_prohibit_gethostname                           FAIL           0.68s (exit status 2)
203/327 libvirt:syntax-check / sc_TAB_in_indentation                             FAIL           0.47s (exit status 2)
203/327 libvirt:syntax-check / sc_TAB_in_indentation                             FAIL           0.47s (exit status 2)
217/327 libvirt:syntax-check / sc_prohibit_int_ijk                               FAIL           0.82s (exit status 2)
217/327 libvirt:syntax-check / sc_prohibit_int_ijk                               FAIL           0.82s (exit status 2)
231/327 libvirt:syntax-check / sc_copyright_usage                                FAIL           0.56s (exit status 2)
231/327 libvirt:syntax-check / sc_copyright_usage                                FAIL           0.56s (exit status 2)
257/327 libvirt:syntax-check / sc_prohibit_sysconf_pagesize                      FAIL           0.65s (exit status 2)
257/327 libvirt:syntax-check / sc_prohibit_sysconf_pagesize                      FAIL           0.65s (exit status 2)
262/327 libvirt:syntax-check / sc_gettext_init                                   FAIL           0.40s (exit status 2)
262/327 libvirt:syntax-check / sc_gettext_init                                   FAIL           0.40s (exit status 2)
264/327 libvirt:syntax-check / sc_prohibit_http_urls                             FAIL           0.54s (exit status 2)
264/327 libvirt:syntax-check / sc_prohibit_http_urls                             FAIL           0.54s (exit status 2)
265/327 libvirt:syntax-check / sc_prohibit_author                                FAIL           0.60s (exit status 2)
265/327 libvirt:syntax-check / sc_prohibit_author                                FAIL           0.60s (exit status 2)
273/327 libvirt:syntax-check / sc_prohibit_strcmp                                FAIL           0.65s (exit status 2)
273/327 libvirt:syntax-check / sc_prohibit_strcmp                                FAIL           0.65s (exit status 2)
279/327 libvirt:syntax-check / sc_require_config_h                               FAIL           0.34s (exit status 2)
279/327 libvirt:syntax-check / sc_require_config_h                               FAIL           0.34s (exit status 2)
280/327 libvirt:syntax-check / sc_require_config_h_first                         FAIL           0.33s (exit status 2)
280/327 libvirt:syntax-check / sc_require_config_h_first                         FAIL           0.33s (exit status 2)
307/327 libvirt:syntax-check / sc_trailing_blank                                 FAIL           0.70s (exit status 2)
307/327 libvirt:syntax-check / sc_trailing_blank                                 FAIL           0.70s (exit status 2)
312/327 libvirt:syntax-check / sc_prohibit_empty_lines_at_EOF                    FAIL           0.40s (exit status 2)
312/327 libvirt:syntax-check / sc_prohibit_empty_lines_at_EOF                    FAIL           0.40s (exit status 2)
313/327 libvirt:syntax-check / sc_prohibit_doubled_word                          FAIL           1.50s (exit status 2)
313/327 libvirt:syntax-check / sc_prohibit_doubled_word                          FAIL           1.50s (exit status 2)
319/327 libvirt:syntax-check / sc_po_check                                       FAIL           0.40s (exit status 2)
319/327 libvirt:syntax-check / sc_po_check                                       FAIL           0.40s (exit status 2)
323/327 libvirt:syntax-check / sc_spacing-check                                  FAIL           2.49s (exit status 2)
323/327 libvirt:syntax-check / sc_spacing-check                                  FAIL           2.49s (exit status 2)

Ok:                 304 
Expected Fail:      0   
Fail:               18  
Unexpected Pass:    0   
Skipped:            5   
Timeout:            0   
make[1]: *** [debian/rules:175: override_dh_auto_test] Error 1
make[1]: Leaving directory '/root/libvirtsource/libvirt-7.0.0'
make: *** [debian/rules:166: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
vitalif commented 3 years ago

No idea, I don't get these failures, in my case libvirt debian packages build successfully. In fact I got one failure during tests but it was unrelated to vitastor - it was caused by /home being a symlink to /var/home on my system.

lnsyyj commented 3 years ago

Thank you, I will look into it again.