vitalsource / LTI2-Reference

MIT License
21 stars 15 forks source link

Alter encoding statements unnecessary. #8

Open preston opened 9 years ago

preston commented 9 years ago

Unless I'm missing something, all the execute(..) calls in the migrations are unneeded if you just set your database encoding correctly to start with. Plus, those types seems to be specific to MySQL and are b0rken on other databases. Works great on Postgres without them.

Thanks a ton for your efforts, and keep up the great work!

jrissler commented 9 years ago

@preston Your 100% right. I can't remember why we had to add those at the time - but it's def covered by just setting encoding from the start now. Thanks.