search

vitaly-t / excellent

Basic DOM Component Framework
https://vitaly-t.github.io/excellent/
MIT License
57 stars 5 forks source link

onReady vs onPostInit #16

Closed vitaly-t closed 6 years ago

vitaly-t commented 6 years ago

I am contemplating one breaking change, before this library hits version 1.0.0 - to rename onPostInit into onReady, to make it shorter, and with more accurate/precise meaning.

If you think this is a good change - please vote, and/or leave your comments below!

vitaly-t commented 6 years ago

Implemented in version 0.9.0.

vitaly-t commented 6 years ago

Following this logic, I should rename the global onInit into onReady also, because inside the app's onInit we are in fact ready to do anything, so it is in fact the onReady state.

This is going to happen for the official 1.0.0 release.

Therefore, re-opening the issue.

vitaly-t commented 6 years ago

Quickly followed up with 0.9.1, renaming the global event.