search

vitaly-t / excellent

Basic DOM Component Framework
https://vitaly-t.github.io/excellent/
MIT License
57 stars 5 forks source link

Need to upgrade Jest #33

Open vitaly-t opened 3 years ago

vitaly-t commented 3 years ago

Newer version of Jest that's used for testing received some breaking changes, which breaks a few of my tests.

Need to figure out how to update my tests to start using the latest Jest.

vitaly-t commented 3 years ago

@adams-brian Brian, you have been incredibly helpful with Jest tests integration here... Maybe you can help with this issue, why I can't upgrade tests from Jest v24 to v27.

Thank you in advance, much appreciate your help!

vitaly-t commented 3 years ago

Fixed all tests but one, with this commit.

So just one test to fix now after Jest upgrade. Seems like there is an issue with OnDestroy not being called.