Rails 4.1 - Githubissues

vitaly / debitcredit

Double Entry Accounting for Rails

MIT License

18 stars 8 forks source link

Rails 4.1 #2

Closed debreczeni closed 9 years ago

debreczeni commented 10 years ago

This branch makes debitcredit rails 4.1 compatible by renaming transaction to entry to avoid collision with built-in ActiveRecord method transaction. Fixes https://github.com/vitaly/debitcredit/issues/1 This pull request does not include an upgrade migration for existing DBs.

vitaly commented 9 years ago

what is the exact problem you are trying to solve. is Transaction reserved? I don't see it in a fresh 4.1 application.

vitaly commented 9 years ago

this one already pulled into https://github.com/vitaly/debitcredit/pull/5

debreczeni commented 9 years ago

Hi @vitaly just replying to you here since this is where you asked the question re: Transaction being reserved or not. It was quite a while but if I can remember well ActiveRecord::Base.transaction was conflicting with transaction when used through an association?

vitaly commented 9 years ago

merged