search

vitalybaev / laravel-dkim

Laravel 5 MailServiceProvider decorator, providing sign outgoing emails with DKIM
MIT License
31 stars 20 forks source link

Override registerIlluminateMailer() instead of register() #19

Closed langemeijer closed 4 years ago

langemeijer commented 4 years ago

Adding laravel5-dkim broke my custom templates. This commit fixes that.

class Illuminate\Mail\MailServiceProvider implements register() as three calls to the methods:

        $this->registerSwiftMailer();
        $this->registerIlluminateMailer();
        $this->registerMarkdownRenderer();

Previously the call to registerMarkdownRenderer() was missing from DkimMailServiceProvider.

I could have added this, but instead I opted to override registerIlluminateMailer() instead, which I find a cleaner solution.

vitalybaev commented 4 years ago

Thanks!