search

vitalyliber / dokku-github-action

Deploy applications to Dokku
https://vitalyliber.com/courses/deploj-prilozhenij-s-dokku
MIT License
78 stars 32 forks source link

Public key is unnecessary #5

Closed nerg4l closed 4 years ago

nerg4l commented 4 years ago

From ssh.com Key Pair - Public and Private

A public key that is copied to the SSH server(s). [...]

Public key has to be stored on the target of the ssh connection inside authorized_keys

A private key that remains (only) with the user. [...]

Private key has to be stored on the client of the ssh connection. (eg. id_rsa)

This means that adding $SSH_PATH/deploy_key.pub is completely unnecessary.

vitalyliber commented 4 years ago

@nerg4l thank you! I will investigate it.

nerg4l commented 4 years ago

My public key is an empty string here: https://github.com/broadcastt/broadcastt-docs/blob/master/.github/workflows/main.yml

As far as know I have to set it because it is set as required: true in action.yml.