vitalyliber / dokku-github-action

Deploy applications to Dokku
https://vitalyliber.com/courses/deploj-prilozhenij-s-dokku
MIT License
78 stars 32 forks source link

Remove DEPLOY_BRANCH (3/4) #9

Closed WilliamMayor closed 4 years ago

WilliamMayor commented 4 years ago

This one I'm a little uncertain about.

The checkout action should set the git repo up with HEAD pointing at the commit that triggered the action. It feels like we can rely on this to set the commit that the user wants to deploy.

It seems to run on my local machine, but I suspect there will be issues when this run in GitHub. At the very least this is a breaking change for people using the action currently.

For deploying the branch/pr that triggered the action I think this method should work.

For deploying a different branch the user will have to give more arguments to the checkout action.