search

vitamin-caig / zxtune

Mirror of http://bitbucket.org/zxtune/zxtune repository with robot-only issues tracker
https://zxtune.bitbucket.io
148 stars 17 forks source link

request to add laytest nsfplay and laytest beta to zxtune? #2188

Open juanreina921 opened 3 years ago

juanreina921 commented 3 years ago

Hey, When it comes to gme for nsf playback, it hasn't been updated for a long time now, and nsf playback is far from accurate, failing to play new nsfs correctly, or not playing them at all. I tested them out with nsfplay, and they work and play correctly. I think it's made with c pluss pluss, and using a version suitable with zxtune. Latest beta and sorce, recommended. []()https://ci.appveyor.com/project/bbbradsmith/nsfplay/branch/master/artifacts Don't worry, link is the same for new versions of nsfplay. I will atach zip with some nsfs, so you can test for yourself.

juanreina921 commented 3 years ago

Heres the archive. There could be more, but this is all I've got for now. don't worry the files will stay there for 21 days. []()http://www.fileconvoy.com/dfl.php?id=g6c2ee0334626a175100032605307a3c906d14eefc5

vitamin-caig commented 3 years ago

I'm not sure nfsplay will fit zxtune requirements for 3rdparty library.

juanreina921 commented 3 years ago

Is there something wrong?

vitamin-caig commented 3 years ago

At first glance:

  1. Japanese comments
  2. Code is not thread-safe and event thread-aware
  3. Almost no metadata accessible (only title)
  4. Unnecessary coupling with UI-related code which is platform-dependent
juanreina921 commented 3 years ago

Oh, I see. Isn't there a player that could be used instead of gme for nsf? Was thinking nezplug pluss pluss, but that too, has japanese comments.

caallaki commented 3 years ago

There is NotsoFatso

IDK if it's suitable for zxtune usage, but it's a really great engine

http://slickproductions.org/notsofatso.php

http://forums.nesdev.com/viewtopic.php?f=6&t=4653