search

vitasdk / newlib

PS Vita Newlib port.
GNU General Public License v2.0
47 stars 29 forks source link

Add strfmon #72

Closed isage closed 2 years ago

isage commented 2 years ago

Requires https://github.com/vitasdk/buildscripts/pull/108

d3m3vilurr commented 2 years ago

Hello @isage, how about we just use copied/modified version of freebsd code? https://github.com/vitasdk/newlib/blob/vita/winsup/cygwin/libc/strfmon.c

isage commented 2 years ago

It is simplified version from musl, which is rather shorter and easier (and we don't have locale support freebsd version requires)

d3m3vilurr commented 2 years ago

sorry for my late review. copying from musl is okay. btw, can you add a license holder to head of copied code? (eg; https://github.com/vitasdk/newlib/blob/190169bc5/newlib/libc/string/strverscmp.c#L35-L56) musl is MIT but newlib is mixed license.

isage commented 2 years ago

Sure, done