search

vitchyr / viskit

rllab's viskit with some added features
73 stars 35 forks source link

Hover label with long name is truncated #9

Closed jendelel closed 5 years ago

jendelel commented 5 years ago

Hi Vitchyr,

I love viskit. Do you think it would be possible to show the whole legend name when hovering over the data? Right now, it truncates shows only the beginning as shown below.

I found this issue on plotly, but adding 

hoverlabel=dict(namelength=-1)

to go.Scatter function for values (link in make_plot function did not fix it for me .

Since viskit is relatively complex I thought I might be missing something that you could help me to spot.

Thanks a lot, Lukas

jendelel commented 5 years ago

Here is a screenshot of what I have in mind. viskit_labels_truncated

vitchyr commented 5 years ago

This seems like a plotly-specific issue, and I don't have an specific ideas for how to address it. If you figure out how to do this, please make a PR and I'll be happy to accept it!

On Fri, Aug 16, 2019, 10:53 AM Lukas Jendele notifications@github.com wrote:

Here is a screenshot of what I have in mind. [image: viskit_labels_truncated] https://user-images.githubusercontent.com/16251857/63159696-67869000-c01c-11e9-8fcf-8e412866bc31.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vitchyr/viskit/issues/9?email_source=notifications&email_token=AAJ4VZONZY77LTDCM5GOUMLQEZ2JDA5CNFSM4IMF4L22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4OGOUA#issuecomment-521955152, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ4VZMFV2RHEH4NGQZWIMLQEZ2JDANCNFSM4IMF4L2Q .

jendelel commented 5 years ago

Hi Vitchyr,

upgrading both Python and embedded JS version of Plotly fixed it for me. I'd be happy to send you a PR if you want (it's 3 lines change).

I noticed that the plots look different and hovering shows only one trace instead of all of them. There are probably more things that changed between the versions. I will stick to the new one as I like the full labels.

Let me know if you want me to send you the PR.

Lukas

vitchyr commented 5 years ago

Would you mind sharing a screenshot of what it looks like?

On Tue, Aug 20, 2019, 3:42 PM Lukas Jendele notifications@github.com wrote:

Hi Vitchyr,

upgrading both Python and embedded JS version of Plotly fixed it for me. I'd be happy to send you a PR if you want (it's 3 lines change).

I noticed that the plots look different and hovering shows only one trace instead of all of them. There are probably more things that changed between the versions. I will stick to the new one as I like the full labels.

Let me know if you want me to send you the PR.

Lukas

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vitchyr/viskit/issues/9?email_source=notifications&email_token=AAJ4VZKDSET4OIC26LEMTRDQFP7GBA5CNFSM4IMF4L22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WRBEA#issuecomment-523047056, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ4VZMN4KZEPFXQ5LX5H7LQFP7GBANCNFSM4IMF4L2Q .

jendelel commented 5 years ago

viskit_new_plotly

vitchyr commented 5 years ago

Could you submit a PR? I'll look over it and then decide.

On Tue, Aug 20, 2019, 4:42 PM Lukas Jendele notifications@github.com wrote:

[image: viskit_new_plotly] https://user-images.githubusercontent.com/16251857/63362257-d6901b80-c371-11e9-9ec1-126a66a01185.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vitchyr/viskit/issues/9?email_source=notifications&email_token=AAJ4VZJ23QX3V6ZFHOPDITLQFQGFPA5CNFSM4IMF4L22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WXOEY#issuecomment-523073299, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ4VZKSJGMEXK2X2QPUOLDQFQGFPANCNFSM4IMF4L2Q .