vite-pwa / assets-generator

Zero-config PWA Assets Generator
https://vite-pwa-org.netlify.app/assets-generator/
MIT License
83 stars 8 forks source link

Update Sharp Dependency to Support Bun #38

Open MehrdadKhnzd opened 4 months ago

MehrdadKhnzd commented 4 months ago

Hi,

You're using sharp@0.32.6 which doesn't work with the Bun runtime. Please consider updating to >0.33 to fix the problem with Bun.

https://github.com/lovell/sharp/issues/3511

Thanks!

kelvindecosta commented 3 months ago

+1

userquin commented 3 months ago

you use latest (sharp and sharp-ico) using resolutions in your package.json, my OS is Windows, I cannot test/run bun on my local :cry:

kelvindecosta commented 3 months ago

I tried to do so but I think this might be the problem: ssnangua/sharp-ico#1

Not entirely sure though...

kelvindecosta commented 3 months ago

When using bun@1.1.0, the resolutions work perfectly!

EKliptus commented 1 month ago

Also, the same needs for compatibility with Astro : https://github.com/vite-pwa/assets-generator/issues/46