search

vite-pwa / docs

Documentation: PWA integrations for Vite and the ecosystem
https://vite-pwa-org.netlify.app/
MIT License
197 stars 44 forks source link

Fix typo #13

Closed piotr-cz closed 1 year ago

piotr-cz commented 1 year ago

As in title

netlify[bot] commented 1 year ago

Deploy Preview for vite-pwa-org ready!

Name Link
Latest commit 69904efae25af4b1dcf50382b96c039373155050
Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/63b5a40ca6b99f0009bdf480
Deploy Preview https://deploy-preview-13--vite-pwa-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

userquin commented 1 year ago

thx, I'll wait to tmr to merge this...

piotr-cz commented 1 year ago

By the way, in my setup workbox-* files are built inside /dist/assets directory. This means that whole code block is not needed as caching for workbox files is already covered

https://github.com/vite-pwa/docs/blob/3d29d10c2ab5b3f5154fe00568d1edf705ec7729/deployment/nginx.md?plain=1#L68-L80

userquin commented 1 year ago

we should cover default Vite options: if someone using a custom setup should deal with it, we cannot cover all cases (i.e your case)

piotr-cz commented 1 year ago

Actually there is only workbox-window file which is created within the /assets directory, It's not specific to my setup, it's the default state.

I'll prepare next PR with the fix.