vite-pwa / docs

Documentation: PWA integrations for Vite and the ecosystem
https://vite-pwa-org.netlify.app/
MIT License
197 stars 44 forks source link

docs: Updates inject-manifest docs to explicitly mention devOptions #14

Closed lukebatchelor closed 1 year ago

lukebatchelor commented 1 year ago

Just a small docs update to hopefully save someone a lot of pain.

Whilst following the docs for injecting a custom service worker I kept running into the Cannot use import statement outside a module error. After spending a long time on it, I eventually found that it's 100% answered in the docs already, so I'm just making that more clear.

I think this could be a pretty common use case, a user is developing a custom service worker, they're reading the custom service worker docs and they're copying the code samples with imports in them, so hopefully this is useful.

Cheers

netlify[bot] commented 1 year ago

Deploy Preview for vite-pwa-org ready!

Name Link
Latest commit 109e62eca78566c8ad21f5cc913a12b2a63a10aa
Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/63b7b684eab44000088e1ffe
Deploy Preview https://deploy-preview-14--vite-pwa-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.