search

vite-pwa / docs

Documentation: PWA integrations for Vite and the ecosystem
https://vite-pwa-org.netlify.app/
MIT License
196 stars 42 forks source link

Clarify "scaffolding PWA project" reusable component #161

Closed pwbriggs closed 2 weeks ago

pwbriggs commented 3 weeks ago

Clarify supported Node.js versions in <ScaffoldingPWAProject />.

netlify[bot] commented 3 weeks ago

Deploy Preview for vite-pwa-org ready!

Name Link
Latest commit 1e86c2b5e8de9b5cdc5d55754699b2fad6b19e5b
Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/666bd8b56b440c0008eb6f57
Deploy Preview https://deploy-preview-161--vite-pwa-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pwbriggs commented 3 weeks ago

thx ❤️ , I just copy/paste the sentence from vite docs: https://vitejs.dev/guide/#scaffolding-your-first-vite-project

Oh, I see. On a side note, that link currently says "Vite requires Node.js version 18+ or 20+." but I didn't use that because I think it's confusing ("how can it be 18 or above and 20 or above?"). I understand what it means, but I think "18.x.x or 20+" is clearer.

userquin commented 3 weeks ago

I'm fine with both