vite-pwa / docs

Documentation: PWA integrations for Vite and the ecosystem
https://vite-pwa-org.netlify.app/
MIT License
197 stars 44 forks source link

Update inject-manifest.md #63

Closed Sisyphusean closed 1 year ago

Sisyphusean commented 1 year ago

In the injectManifest:{rollupFormat: 'iife'}, the rollup format was specified as iief instead of iife. It was like that in the comment as well. I've corrected it to say IIFE.

Ran this while facing the vague exports error myself. "iife" is the correct term to be passed to the rollup options not "iief".

netlify[bot] commented 1 year ago

Deploy Preview for vite-pwa-org ready!

Name Link
Latest commit a05363c494a4802eb65fae0e86b98929e1fdf4b1
Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/64a54c248cfc8f000848cee0
Deploy Preview https://deploy-preview-63--vite-pwa-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brc-dd commented 1 year ago

faq.md has this issue too 👀

userquin commented 1 year ago

thx @brc-dd for reporting... should be fixed now

brc-dd commented 1 year ago

https://github.com/vite-pwa/docs/blob/53874234288da80032b7eae29ff6673079b4d1f4/guide/faq.md#L30 too 😅

userquin commented 1 year ago

fixed

userquin commented 1 year ago

@brc-dd are you going to add pwa to VP?

Sisyphusean commented 1 year ago

Yeah it's fixed.

I apologize if this is not the right place to mention this but I feel like this Advanced page should at least be linked in the Overall Inject Manifest documentation (found here).

It's especially important as the inject Manifest option being provided as iife blocked me from being able to transpile my service worker until I went around scouring the docs.

I feel like it would save a lot of time for beginners like myself

userquin commented 1 year ago

@Sisyphusean PR welcome

brc-dd commented 1 year ago

@brc-dd are you going to add pwa to VP?

The official site or in the docs?

userquin commented 1 year ago

The official site or in the docs?

VP docs

brc-dd commented 1 year ago

The docs at https://vite-pwa-org.netlify.app/frameworks/vitepress.html seem fine. We could probably add a link somewhere in the guide? Or create a dedicated page for plugins?